OSDN Git Service

machine: query dump-guest-core machine property
authorMarcel Apfelbaum <marcel@redhat.com>
Wed, 4 Feb 2015 15:43:54 +0000 (17:43 +0200)
committerMichael S. Tsirkin <mst@redhat.com>
Wed, 11 Mar 2015 17:17:54 +0000 (18:17 +0100)
commit47c8ca533e502955a4e1b24056639c79500ab8f8
treef96c0f4e8c5cf016f240fa0422cdd017c6ef21da
parent66bd56694beef7fb8687767e6bec0264227c6b14
machine: query dump-guest-core machine property

Running
    qemu-bin ... -machine pc,dump-guest-core=on
leads to crash:
    x86_64-softmmu/qemu-system-x86_64 -machine pc,dump-guest-core=on
    qemu-system-x86_64: qemu/util/qemu-option.c:387: qemu_opt_get_bool_helper:
    Assertion `opt->desc && opt->desc->type == QEMU_OPT_BOOL' failed.  Aborted
    (core dumped)

This happens because the commit e79d5a6 ("machine: remove qemu_machine_opts
global list") removed the global option descriptions and moved them to
MachineState's QOM properties.

Fix this by querying machine properties through designated wrappers.

Signed-off-by: Marcel Apfelbaum <marcel@redhat.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
exec.c
hw/core/machine.c
include/hw/boards.h