OSDN Git Service

dmaengine: axi-dmac: Use struct_size() in kzalloc()
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Wed, 9 Jan 2019 14:44:37 +0000 (08:44 -0600)
committerVinod Koul <vkoul@kernel.org>
Sun, 20 Jan 2019 05:21:38 +0000 (10:51 +0530)
commit48b02a85fe2e6a0927acaa754ba3bef4a20a5e37
tree3c0461df6c7d61a081a7c346e996faacac91d8a9
parent3c215fd868dd9fe077af63dbddca585e5116f598
dmaengine: axi-dmac: Use struct_size() in kzalloc()

One of the more common cases of allocation size calculations is finding the
size of a structure that has a zero-sized array at the end, along with memory
for some number of elements for that array. For example:

struct foo {
    int stuff;
    void *entry[];
};

instance = kzalloc(sizeof(struct foo) + sizeof(void *) * count, GFP_KERNEL);

Instead of leaving these open-coded and prone to type mistakes, we can now
use the new struct_size() helper:

instance = kzalloc(struct_size(instance, entry, count), GFP_KERNEL);

This code was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/dma-axi-dmac.c