OSDN Git Service

drm/ttm: fix use-after-free races in vm fault handling
authorNicolai Hähnle <nicolai.haehnle@amd.com>
Sat, 18 Feb 2017 21:59:56 +0000 (22:59 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 14 May 2017 12:00:22 +0000 (14:00 +0200)
commit48d9fa1ece5ee453d4c08a7feec74c966939a25c
treecfd58eb3c5d8e4558852076f0f7bdaa1a0a4e9cf
parent347d07bf3add9bc1a7d52fad2f8efea61aa75c38
drm/ttm: fix use-after-free races in vm fault handling

commit 3089c1df10e2931b1d72d2ffa7d86431084c86b3 upstream.

The vm fault handler relies on the fact that the VMA owns a reference
to the BO. However, once mmap_sem is released, other tasks are free to
destroy the VMA, which can lead to the BO being freed. Fix two code
paths where that can happen, both related to vm fault retries.

Found via a lock debugging warning which flagged &bo->wu_mutex as
locked while being destroyed.

Fixes: cbe12e74ee4e ("drm/ttm: Allow vm fault retries")
Signed-off-by: Nicolai Hähnle <nicolai.haehnle@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/gpu/drm/ttm/ttm_bo_vm.c