OSDN Git Service

cirrus: cs89x0: fix the return value handle and remove redundant dev_warn() for platf...
authorRuan Jinjie <ruanjinjie@huawei.com>
Tue, 1 Aug 2023 13:31:21 +0000 (21:31 +0800)
committerJakub Kicinski <kuba@kernel.org>
Wed, 2 Aug 2023 19:10:39 +0000 (12:10 -0700)
commit497c3a5fb3ed4a59c4d3c460c70393dd609815dc
treecf8f30266a98f09a53dc1aa185b2221ac2ac350a
parentae3683a34265381cd4bc006295a091009c7215d1
cirrus: cs89x0: fix the return value handle and remove redundant dev_warn() for platform_get_irq()

There is no possible for platform_get_irq() to return 0
and the return value of platform_get_irq() is more sensible
to show the error reason.

And there is no need to call the dev_warn() function directly to print
a custom message when handling an error from platform_get_irq() function as
it is going to display an appropriate error message in case of a failure.

Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Reviewed-by: Alex Elder <elder@linaro.org>
Link: https://lore.kernel.org/r/20230801133121.416319-1-ruanjinjie@huawei.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/cirrus/cs89x0.c