OSDN Git Service

hw/net/e1000e: Remove overwritten read handler for STATUS register
authorPhilippe Mathieu-Daudé <f4bug@amsat.org>
Fri, 4 Sep 2020 13:14:01 +0000 (15:14 +0200)
committerLaurent Vivier <laurent@vivier.eu>
Thu, 10 Sep 2020 14:20:49 +0000 (16:20 +0200)
commit4a4a604cc60cb94525fc4c2d1230557c1e7d166d
tree6493952ee6fff410770d56137d30bdc3e64299c5
parentc857f9050cff9eb02ff05e901152dc1570f798bd
hw/net/e1000e: Remove overwritten read handler for STATUS register

The STATUS register readop handler is initialized first with
the generic e1000e_mac_readreg() handler:

  2861 #define e1000e_getreg(x)    [x] = e1000e_mac_readreg
  2862 typedef uint32_t (*readops)(E1000ECore *, int);
  2863 static const readops e1000e_macreg_readops[] = {
  ....
  2919     e1000e_getreg(STATUS),

Then overwritten with the specific e1000e_get_status handler:

  3018     [STATUS]  = e1000e_get_status,

To avoid confusion, remove the overwritten initialization.

6f3fbe4ed0 ("net: Introduce e1000e device emulation")
Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Li Qiang <liq3ea@gmail.com>
Message-Id: <20200904131402.590055-2-f4bug@amsat.org>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
hw/net/e1000e_core.c