OSDN Git Service

target/riscv/pmp.c: pmpcfg_csr_read returns bogus value on RV64
authorDayeol Lee <dayeol@berkeley.edu>
Fri, 26 Oct 2018 18:04:27 +0000 (18:04 +0000)
committerPalmer Dabbelt <palmer@sifive.com>
Tue, 30 Oct 2018 18:04:28 +0000 (11:04 -0700)
commit4a9b31b82bcd2cafe85137334f1c07afe56cc224
tree36ec3dd8fb1e8bcacfa3f8024c5a215fb92582ea
parenta2e002ff7913ce93aa0f7dbedd2123dce5f1a9cd
target/riscv/pmp.c: pmpcfg_csr_read returns bogus value on RV64

pmp_read_cfg() returns 8-bit value, which is combined together to form a single pmpcfg CSR.
The default promotion rules will result in an integer here ("i*8" is integer, which
flows through) resulting in a 32-bit signed value on most hosts.
That's bogus on RV64I, with the high bits of the CSR being wrong.

Signed-off-by: Dayeol Lee <dayeol@berkeley.edu>
Reviewed-by: Palmer Dabbelt <palmer@sifive.com>
Reviewed-by: Alistair Francis <alistair.francis@wdc.com>
Signed-off-by: Palmer Dabbelt <palmer@sifive.com>
target/riscv/pmp.c