OSDN Git Service

bpf: udp: ipv6: Avoid running reuseport's bpf_prog from __udp6_lib_err
authorMartin KaFai Lau <kafai@fb.com>
Fri, 31 May 2019 22:29:11 +0000 (15:29 -0700)
committerAlexei Starovoitov <ast@kernel.org>
Mon, 3 Jun 2019 20:38:48 +0000 (13:38 -0700)
commit4ac30c4b3659efac031818c418beb51e630d512d
treec595332075bea5ffdc4905627b2e632c9b638fb9
parent1e692f09e091bf5c8b38384f297d6dae5dbf0f12
bpf: udp: ipv6: Avoid running reuseport's bpf_prog from __udp6_lib_err

__udp6_lib_err() may be called when handling icmpv6 message. For example,
the icmpv6 toobig(type=2).  __udp6_lib_lookup() is then called
which may call reuseport_select_sock().  reuseport_select_sock() will
call into a bpf_prog (if there is one).

reuseport_select_sock() is expecting the skb->data pointing to the
transport header (udphdr in this case).  For example, run_bpf_filter()
is pulling the transport header.

However, in the __udp6_lib_err() path, the skb->data is pointing to the
ipv6hdr instead of the udphdr.

One option is to pull and push the ipv6hdr in __udp6_lib_err().
Instead of doing this, this patch follows how the original
commit 538950a1b752 ("soreuseport: setsockopt SO_ATTACH_REUSEPORT_[CE]BPF")
was done in IPv4, which has passed a NULL skb pointer to
reuseport_select_sock().

Fixes: 538950a1b752 ("soreuseport: setsockopt SO_ATTACH_REUSEPORT_[CE]BPF")
Cc: Craig Gallek <kraig@google.com>
Signed-off-by: Martin KaFai Lau <kafai@fb.com>
Acked-by: Song Liu <songliubraving@fb.com>
Acked-by: Craig Gallek <kraig@google.com>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
net/ipv6/udp.c