OSDN Git Service

sfc: detach from cb_page in efx_copy_channel()
authorEdward Cree <ecree@solarflare.com>
Mon, 9 Mar 2020 18:16:24 +0000 (18:16 +0000)
committerDavid S. Miller <davem@davemloft.net>
Tue, 10 Mar 2020 00:44:05 +0000 (17:44 -0700)
commit4b1bd9db078f7d5332c8601a2f5bd43cf0458fd4
tree025b5e6179204b4b5664678d088bd35f6bd2f97c
parent661388f9b0004421b2ecdeac17248bd92a3bb818
sfc: detach from cb_page in efx_copy_channel()

It's a resource, not a parameter, so we can't copy it into the new
 channel's TX queues, otherwise aliasing will lead to resource-
 management bugs if the channel is subsequently torn down without
 being initialised.

Before the Fixes:-tagged commit there was a similar bug with
 tsoh_page, but I'm not sure it's worth doing another fix for such
 old kernels.

Fixes: e9117e5099ea ("sfc: Firmware-Assisted TSO version 2")
Suggested-by: Derek Shute <Derek.Shute@stratus.com>
Signed-off-by: Edward Cree <ecree@solarflare.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/sfc/efx_channels.c