OSDN Git Service

mutex: Don't spin when the owner CPU is offline or other weird cases
authorBenjamin Herrenschmidt <benh@kernel.crashing.org>
Fri, 16 Apr 2010 21:20:00 +0000 (23:20 +0200)
committerIngo Molnar <mingo@elte.hu>
Fri, 23 Apr 2010 09:00:28 +0000 (11:00 +0200)
commit4b402210486c6414fe5fbfd85934a0a22da56b04
tree23e7052c710e0443ccd895a1000b2bdd7723ab51
parentd5a30458a90597915977f06e79406b664a41b8ac
mutex: Don't spin when the owner CPU is offline or other weird cases

Due to recent load-balancer changes that delay the task migration to
the next wakeup, the adaptive mutex spinning ends up in a live lock
when the owner's CPU gets offlined because the cpu_online() check
lives before the owner running check.

This patch changes mutex_spin_on_owner() to return 0 (don't spin) in
any case where we aren't sure about the owner struct validity or CPU
number, and if the said CPU is offline. There is no point going back &
re-evaluate spinning in corner cases like that, let's just go to
sleep.

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
LKML-Reference: <1271212509.13059.135.camel@pasglop>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
kernel/sched.c