OSDN Git Service

ath10k: add missing error handling
authorClaire Chang <tientzu@chromium.org>
Thu, 23 May 2019 07:15:34 +0000 (15:15 +0800)
committerKalle Valo <kvalo@codeaurora.org>
Tue, 25 Jun 2019 12:58:23 +0000 (15:58 +0300)
commit4b553f3ca4cbde67399aa3a756c37eb92145b8a1
treec31f1cb07d23042db3d948cab0ea351293de5ac1
parent4fa42adebe5b77215e50eaad701663c8702d3c88
ath10k: add missing error handling

In function ath10k_sdio_mbox_rx_alloc() [sdio.c],
ath10k_sdio_mbox_alloc_rx_pkt() is called without handling the error cases.
This will make the driver think the allocation for skb is successful and
try to access the skb. If we enable failslab, system will easily crash with
NULL pointer dereferencing.

Call trace of CONFIG_FAILSLAB:
ath10k_sdio_irq_handler+0x570/0xa88 [ath10k_sdio]
process_sdio_pending_irqs+0x4c/0x174
sdio_run_irqs+0x3c/0x64
sdio_irq_work+0x1c/0x28

Fixes: d96db25d2025 ("ath10k: add initial SDIO support")
Signed-off-by: Claire Chang <tientzu@chromium.org>
Reviewed-by: Brian Norris <briannorris@chromium.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/ath/ath10k/sdio.c