OSDN Git Service

migration: Define BLK_MIG_BLOCK_SIZE as unsigned long long
authorPeter Maydell <peter.maydell@linaro.org>
Thu, 21 Jul 2022 11:52:07 +0000 (12:52 +0100)
committerDr. David Alan Gilbert <dgilbert@redhat.com>
Tue, 2 Aug 2022 15:46:52 +0000 (16:46 +0100)
commit4bcb7de072fd8ab9de40b24aac00c7b6659f7f7d
treef3255476c4b51d8e9c1f61c49ac4d255674edd9f
parentead34f64f97d11626774a57863ca285a7ddc0d18
migration: Define BLK_MIG_BLOCK_SIZE as unsigned long long

When we use BLK_MIG_BLOCK_SIZE in expressions like
block_mig_state.submitted * BLK_MIG_BLOCK_SIZE, this multiplication
is done as 32 bits, because both operands are 32 bits.  Coverity
complains about possible overflows because we then accumulate that
into a 64 bit variable.

Define BLK_MIG_BLOCK_SIZE as unsigned long long using the ULL suffix.
The only two current uses of it with this problem are both in
block_save_pending(), so we could just cast to uint64_t there, but
using the ULL suffix is simpler and ensures that we don't
accidentally introduce new variants of the same issue in future.

Resolves: Coverity CID 14871361487175
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Message-Id: <20220721115207.729615-3-peter.maydell@linaro.org>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
migration/block.c