OSDN Git Service

drm/amd/display: Fix bug in debugfs crc_win_update entry
authorWayne Lin <Wayne.Lin@amd.com>
Fri, 26 Nov 2021 07:19:57 +0000 (15:19 +0800)
committerAlex Deucher <alexander.deucher@amd.com>
Tue, 7 Dec 2021 18:10:38 +0000 (13:10 -0500)
commit4bef85d4c9491415b7931407b07f24841c1e0390
tree8ee34505f6b343e0c3530fffd00e76039ba23a13
parenta1f5e392de78f122629412d6e4350d1c887f1711
drm/amd/display: Fix bug in debugfs crc_win_update entry

[Why]
crc_rd_wrk shouldn't be null in crc_win_update_set(). Current programming
logic is inconsistent in crc_win_update_set().

[How]
Initially, return if crc_rd_wrk is NULL. Later on, we can use member of
crc_rd_wrk safely.

Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Fixes: 9a65df193108 ("drm/amd/display: Use PSP TA to read out crc")

Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira@amd.com>
Acked-by: Pavle Kotarac <Pavle.Kotarac@amd.com>
Signed-off-by: Wayne Lin <Wayne.Lin@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_debugfs.c