OSDN Git Service

driver core: bus: Goto appropriate labels on failure in bus_add_device
authorJunjie Mao <junjie_mao@yeah.net>
Wed, 28 Jan 2015 02:02:44 +0000 (10:02 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 6 May 2015 20:04:08 +0000 (22:04 +0200)
commit4c0a56b2ee7b3a3741339e943acd2692c146fcb1
treecfe63d254e6390cdcda4f55a940d810a2a035533
parent6361409a1274060993b246c688c24a7c863c7eeb
driver core: bus: Goto appropriate labels on failure in bus_add_device

commit 1c34203a1496d1849ba978021b878b3447d433c8 upstream.

It is not necessary to call device_remove_groups() when device_add_groups()
fails.

The group added by device_add_groups() should be removed if sysfs_create_link()
fails.

Fixes: fa6fdb33b486 ("driver core: bus_type: add dev_groups")
Signed-off-by: Junjie Mao <junjie_mao@yeah.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/base/bus.c