OSDN Git Service

spi: spi-geni-qcom: Select FIFO mode for chip select
authorVijaya Krishna Nivarthi <quic_vnivarth@quicinc.com>
Tue, 9 May 2023 10:01:36 +0000 (15:31 +0530)
committerMark Brown <broonie@kernel.org>
Thu, 11 May 2023 01:18:35 +0000 (10:18 +0900)
commit4c329f5da7cfa366bacfda1328a025dd38951317
treea3ddbbe3311357dd8fa8f0694f8e061c4e08a7b7
parentac9a78681b921877518763ba0e89202254349d1b
spi: spi-geni-qcom: Select FIFO mode for chip select

Spi geni driver switches between FIFO and DMA modes based on xfer length.
FIFO mode relies on M_CMD_DONE_EN interrupt for completion while DMA mode
relies on XX_DMA_DONE.
During dynamic switching, if FIFO mode is chosen, FIFO related interrupts
are enabled and DMA related interrupts are disabled. And viceversa.
Chip select shares M_CMD_DONE_EN interrupt with FIFO to check completion.
Now, if a chip select operation is preceded by a DMA xfer, M_CMD_DONE_EN
interrupt would have been disabled and hence it will never receive one
resulting in timeout.

For chip select, in addition to setting the xfer mode to FIFO,
select_mode() to FIFO so that required interrupts are enabled.

Fixes: e5f0dfa78ac7 ("spi: spi-geni-qcom: Add support for SE DMA mode")
Suggested-by: Praveen Talari <quic_ptalari@quicinc.com
Signed-off-by: Vijaya Krishna Nivarthi <quic_vnivarth@quicinc.com
Reviewed-by: Douglas Anderson <dianders@chromium.org
Link: https://lore.kernel.org/r/1683626496-9685-1-git-send-email-quic_vnivarth@quicinc.com
Signed-off-by: Mark Brown <broonie@kernel.org
drivers/spi/spi-geni-qcom.c