OSDN Git Service

tipc: fix nullptr crash during subscription cancel
authorParthasarathy Bhuvaragan <parthasarathy.bhuvaragan@ericsson.com>
Thu, 3 Mar 2016 16:54:54 +0000 (17:54 +0100)
committerDavid S. Miller <davem@davemloft.net>
Mon, 7 Mar 2016 04:00:08 +0000 (23:00 -0500)
commit4de13d7ed6ffdcbb34317acaa9236f121176f5f8
treef4a7b6dbc9a3779e18e02ed0534222804b31007b
parent11f7f79b40ebfbac6a1bcdbc61d5d13d365e744b
tipc: fix nullptr crash during subscription cancel

commit 4d5cfcba2f6e ('tipc: fix connection abort during subscription
cancel'), removes the check for a valid subscription before calling
tipc_nametbl_subscribe().

This will lead to a nullptr exception when we process a
subscription cancel request. For a cancel request, a null
subscription is passed to tipc_nametbl_subscribe() resulting
in exception.

In this commit, we call tipc_nametbl_subscribe() only for
a valid subscription.

Fixes: 4d5cfcba2f6e ('tipc: fix connection abort during subscription cancel')
Reported-by: Anders Widell <anders.widell@ericsson.com>
Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvaragan@ericsson.com>
Acked-by: Jon Maloy <jon.maloy@ericsson.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/tipc/subscr.c