OSDN Git Service

btrfs: free block groups after free'ing fs trees
authorJosef Bacik <josef@toxicpanda.com>
Tue, 21 Jan 2020 14:17:06 +0000 (09:17 -0500)
committerDavid Sterba <dsterba@suse.com>
Thu, 23 Jan 2020 16:24:39 +0000 (17:24 +0100)
commit4e19443da1941050b346f8fc4c368aa68413bc88
tree70816e547a25898f7e49e0d753edf6767235a796
parent1362089d2ad7e20d16371b39d3c11990d4ec23e4
btrfs: free block groups after free'ing fs trees

Sometimes when running generic/475 we would trip the
WARN_ON(cache->reserved) check when free'ing the block groups on umount.
This is because sometimes we don't commit the transaction because of IO
errors and thus do not cleanup the tree logs until at umount time.

These blocks are still reserved until they are cleaned up, but they
aren't cleaned up until _after_ we do the free block groups work.  Fix
this by moving the free after free'ing the fs roots, that way all of the
tree logs are cleaned up and we have a properly cleaned fs.  A bunch of
loops of generic/475 confirmed this fixes the problem.

CC: stable@vger.kernel.org # 4.9+
Signed-off-by: Josef Bacik <josef@toxicpanda.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/disk-io.c