OSDN Git Service

bootconfig: Prohibit re-defining value on same key
authorMasami Hiramatsu <mhiramat@kernel.org>
Fri, 21 Feb 2020 08:13:42 +0000 (17:13 +0900)
committerSteven Rostedt (VMware) <rostedt@goodmis.org>
Fri, 21 Feb 2020 14:59:19 +0000 (09:59 -0500)
commit4e4694d8729f7cd6381f6691e8f83e378fce3160
treeb7c07e9ddd7681384ee330e6f8c64273c3ed52ec
parent88b913718db94697497028b85acbec8b180a4333
bootconfig: Prohibit re-defining value on same key

Currently, bootconfig adds a new value on the existing key to the tail of an
array. But this looks a bit confusing because an admin can easily rewrite
the original value in the same config file.

This rejects the following value re-definition.

  key = value1
  ...
  key = value2

You should rewrite value1 to value2 in this case.

Link: http://lkml.kernel.org/r/158227282199.12842.10110929876059658601.stgit@devnote2
Suggested-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
[ Fixed spelling of arraies to arrays ]
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Documentation/admin-guide/bootconfig.rst
lib/bootconfig.c
tools/bootconfig/samples/bad-samekey.bconf [new file with mode: 0644]