OSDN Git Service

memory: fsl_ifc: fix leak of irq and nand_irq in fsl_ifc_ctrl_probe
authorDongliang Mu <mudongliangabcd@gmail.com>
Sat, 25 Sep 2021 15:14:32 +0000 (23:14 +0800)
committerKrzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Thu, 7 Oct 2021 18:39:17 +0000 (20:39 +0200)
commit4ed2f3545c2e5acfbccd7f85fea5b1a82e9862d7
tree25adad4715b32445511c268ef990900c524d6f92
parent13f995ceb4e0d669e293aedaaaea07e7b8a5792a
memory: fsl_ifc: fix leak of irq and nand_irq in fsl_ifc_ctrl_probe

The error handling code of fsl_ifc_ctrl_probe is problematic. When
fsl_ifc_ctrl_init fails or request_irq of fsl_ifc_ctrl_dev->irq fails,
it forgets to free the irq and nand_irq. Meanwhile, if request_irq of
fsl_ifc_ctrl_dev->nand_irq fails, it will still free nand_irq even if
the request_irq is not successful.

Fix this by refactoring the error handling code.

Fixes: d2ae2e20fbdd ("driver/memory:Move Freescale IFC driver to a common driver")
Signed-off-by: Dongliang Mu <mudongliangabcd@gmail.com>
Link: https://lore.kernel.org/r/20210925151434.8170-1-mudongliangabcd@gmail.com
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
drivers/memory/fsl_ifc.c