OSDN Git Service

xfs: don't print warnings when xfs_log_force fails
authorChristoph Hellwig <hch@lst.de>
Thu, 2 Feb 2017 07:55:57 +0000 (08:55 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 4 Feb 2017 08:47:11 +0000 (09:47 +0100)
commit4f4d5082ec73f6e0bd44a8eccbef440b96f46a98
tree867c6a2cd2ececeb0dfbca1d77473779361e23ba
parente9b77651910722cd74a3936f230366503089bc80
xfs: don't print warnings when xfs_log_force fails

commit 84a4620cfe97c9d57e39b2369bfb77faff55063d upstream.

There are only two reasons for xfs_log_force / xfs_log_force_lsn to fail:
one is an I/O error, for which xlog_bdstrat already logs a warning, and
the second is an already shutdown log due to a previous I/O errors.  In
the latter case we'll already have a previous indication for the actual
error, but the large stream of misleading warnings from xfs_log_force
will probably scroll it out of the message buffer.

Simply removing the warnings thus makes the XFS log reporting significantly
better.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/xfs/xfs_log.c