OSDN Git Service

cxl: Route eeh events to all drivers in cxl_pci_error_detected()
authorVaibhav Jain <vaibhav@linux.vnet.ibm.com>
Thu, 27 Apr 2017 05:28:22 +0000 (10:58 +0530)
committerMichael Ellerman <mpe@ellerman.id.au>
Tue, 2 May 2017 12:41:42 +0000 (22:41 +1000)
commit4f58f0bf155e87dda31a3088b1e107fa9dd79f0e
tree2862a990503edd8c443742c6665d35caafa90ee7
parentea9a26d117cf0637c71d3e0076f4a124bf5859df
cxl: Route eeh events to all drivers in cxl_pci_error_detected()

Fix a boundary condition where in some cases an eeh event that results
in card reset isn't passed on to a driver attached to the virtual PCI
device associated with a slice. This will happen in case when a slice
attached device driver returns a value other than
PCI_ERS_RESULT_NEED_RESET from the eeh error_detected() callback. This
would result in an early return from cxl_pci_error_detected() and
other drivers attached to other AFUs on the card wont be notified.

The patch fixes this by making sure that all slice attached
device-drivers are notified and the return values from
error_detected() callback are aggregated in a scheme where request for
'disconnect' trumps all and 'none' trumps 'need_reset'.

Fixes: 9e8df8a21963 ("cxl: EEH support")
Cc: stable@vger.kernel.org # v4.3+
Signed-off-by: Vaibhav Jain <vaibhav@linux.vnet.ibm.com>
Reviewed-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
Acked-by: Frederic Barrat <fbarrat@linux.vnet.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
drivers/misc/cxl/pci.c