OSDN Git Service

qed: Use dma_set_mask_and_coherent() and simplify code
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Sun, 2 Jan 2022 09:20:05 +0000 (10:20 +0100)
committerDavid S. Miller <davem@davemloft.net>
Sun, 2 Jan 2022 16:14:30 +0000 (16:14 +0000)
commit4f9f531e1505a126b4d66d8a8a29e8e54fa4075c
tree2db794376e0467bc5bfdde1987e1a70515ce3521
parent1aae5cc0a55c097f16ccce1493415c63d60babc9
qed: Use dma_set_mask_and_coherent() and simplify code

Use dma_set_mask_and_coherent() instead of unrolling it with some
dma_set_mask()+dma_set_coherent_mask().

Moreover, as stated in [1], dma_set_mask() with a 64-bit mask will never
fail if dev->dma_mask is non-NULL.
So, if it fails, the 32 bits case will also fail for the same reason.

Simplify code and remove some dead code accordingly.

Now that qed_set_coherency_mask() is mostly a single call to
dma_set_mask_and_coherent(), fold it in its only caller.

[1]: https://lkml.org/lkml/2021/6/7/398

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/qlogic/qed/qed_main.c