OSDN Git Service

migration: fix potential overflow in multifd send
authorPeter Xu <peterx@redhat.com>
Fri, 20 Jul 2018 03:47:13 +0000 (11:47 +0800)
committerDr. David Alan Gilbert <dgilbert@redhat.com>
Tue, 24 Jul 2018 15:58:51 +0000 (16:58 +0100)
commit4fcefd44a074008e490ff54c3c28a08b8dbfb14b
tree48117842c76a8dc97978d8dbba58ea9dd1e3cbb4
parent3bae150448dbd888a480f892ebbf01caec0d8329
migration: fix potential overflow in multifd send

I would guess it won't happen normally, but this should ease Coverity.

>>>     CID 1394385:  Integer handling issues  (OVERFLOW_BEFORE_WIDEN)
>>>     Potentially overflowing expression "pages->used * 8192U" with type "unsigned int" (32 bits, unsigned) is evaluated using 32-bit arithmetic, and then used in a context that expects an expression of type "uint64_t" (64 bits, unsigned).
854         transferred = pages->used * TARGET_PAGE_SIZE + p->packet_len;

Fixes: CID 1394385
CC: Juan Quintela <quintela@redhat.com>
Signed-off-by: Peter Xu <peterx@redhat.com>
Message-Id: <20180720034713.11711-1-peterx@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
migration/ram.c