OSDN Git Service

pinctrl: madera: Fix uninitialized variable bug in madera_mux_set_mux
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Wed, 10 Oct 2018 15:13:13 +0000 (17:13 +0200)
committerLinus Walleij <linus.walleij@linaro.org>
Fri, 12 Oct 2018 09:14:38 +0000 (11:14 +0200)
commit4fe81669df50889ff1072c030c59df5f1fa6534e
tree63196408e0988bff9187192c68c1dec94338a5ed
parenta85c928f6a7856a09e47d9b37faa3407c7ac6a8e
pinctrl: madera: Fix uninitialized variable bug in madera_mux_set_mux

There is a potential execution path in which variable *ret* is checked
in an IF statement, and then its value is used to report an error at
line 659 without being properly initialized previously:

659 if (ret)
660 dev_err(priv->dev, "Failed to write to 0x%x (%d)\n", reg, ret);

Fix this by initializing variable *ret* to 0 in order to
avoid unpredictable or unintended results.

Addresses-Coverity-ID: 1471969 ("Uninitialized scalar variable")
Fixes: 218d72a77b0b ("pinctrl: madera: Add driver for Cirrus Logic Madera codecs")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/pinctrl/cirrus/pinctrl-madera-core.c