OSDN Git Service

staging: slicoss: Add error check for pci_map_single
authorAmitoj Kaur Chawla <amitoj1606@gmail.com>
Sat, 12 Mar 2016 09:31:04 +0000 (15:01 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 28 Mar 2016 14:30:36 +0000 (07:30 -0700)
commit514dd88df707a1094e937c20d5a0b1ec619e1f96
tree48e2aae5fcc280530df1137ca9a99ace19a29cde
parentafb105549d4879018e45bbf77e76034237d8fc20
staging: slicoss: Add error check for pci_map_single

Currently, DMA mapping failure is not detected, causing the hardware
to attempt a DMA from an invalid address.

This patch adds the corresponding error check for pci_map_single i.e.
pci_dma_mapping_error.

Problem found using the following Coccinelle semantic patch:
// <smpl>
@@
expression e1;
identifier x;
@@
 x=
(
*dma_map_single(...)
|
*dma_map_page(...)
)
... when != dma_mapping_error(e1,x)
@@
expression e1;
identifier x;
@@

 x =
(
*pci_map_single(...)
|
*pci_map_page(...)
)
 ... when != pci_dma_mapping_error(e1,x)
// </smpl>

Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/slicoss/slicoss.c