OSDN Git Service

efifb: BGRT: Improve efifb_bgrt_sanity_check
authorHans de Goede <hdegoede@redhat.com>
Sun, 21 Jul 2019 13:19:18 +0000 (15:19 +0200)
committerBartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Mon, 19 Aug 2019 13:52:23 +0000 (15:52 +0200)
commit51677dfcc17f88ed754143df670ff064eae67f84
tree41d94359f8d19d51cb2eb1d162d6241a8d267fd8
parentd777478599f781fc5162d1ae95dbee6e5ae05a41
efifb: BGRT: Improve efifb_bgrt_sanity_check

For various reasons, at least with x86 EFI firmwares, the xoffset and
yoffset in the BGRT info are not always reliable.

Extensive testing has shown that when the info is correct, the
BGRT image is always exactly centered horizontally (the yoffset variable
is more variable and not always predictable).

This commit simplifies / improves the bgrt_sanity_check to simply
check that the BGRT image is exactly centered horizontally and skips
(re)drawing it when it is not.

This fixes the BGRT image sometimes being drawn in the wrong place.

Cc: stable@vger.kernel.org
Fixes: 88fe4ceb2447 ("efifb: BGRT: Do not copy the boot graphics for non native resolutions")
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Cc: Peter Jones <pjones@redhat.com>,
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190721131918.10115-1-hdegoede@redhat.com
drivers/video/fbdev/efifb.c