OSDN Git Service

atm: fix atm_dev refcnt leaks in atmtcp_remove_persistent
authorXin Xiong <xiongx18@fudan.edu.cn>
Wed, 29 Jul 2020 13:06:59 +0000 (21:06 +0800)
committerDavid S. Miller <davem@davemloft.net>
Fri, 31 Jul 2020 00:35:53 +0000 (17:35 -0700)
commit51875dad43b44241b46a569493f1e4bfa0386d86
tree31e2041f798d1a07bc34de829316aac83526cc41
parent555a893303872e044fb86f0a5834ce78d41ad2e2
atm: fix atm_dev refcnt leaks in atmtcp_remove_persistent

atmtcp_remove_persistent() invokes atm_dev_lookup(), which returns a
reference of atm_dev with increased refcount or NULL if fails.

The refcount leaks issues occur in two error handling paths. If
dev_data->persist is zero or PRIV(dev)->vcc isn't NULL, the function
returns 0 without decreasing the refcount kept by a local variable,
resulting in refcount leaks.

Fix the issue by adding atm_dev_put() before returning 0 both when
dev_data->persist is zero or PRIV(dev)->vcc isn't NULL.

Signed-off-by: Xin Xiong <xiongx18@fudan.edu.cn>
Signed-off-by: Xiyu Yang <xiyuyang19@fudan.edu.cn>
Signed-off-by: Xin Tan <tanxin.ctf@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/atm/atmtcp.c