OSDN Git Service

hw/nvme: add missing return statement
authorDmitry Tikhov <d.tihov@yadro.com>
Fri, 15 Apr 2022 20:48:32 +0000 (23:48 +0300)
committerKlaus Jensen <k.jensen@samsung.com>
Fri, 3 Jun 2022 19:48:24 +0000 (21:48 +0200)
commit51c453266309166c2737623211c0afc12884cccd
tree137b7a9ebfdff42b51a8b21b33fccbfe70826409
parent1e64facc015e16d8e4efa239feaeda9e4e9aeb04
hw/nvme: add missing return statement

Since there is no return after nvme_dsm_cb invocation, metadata
associated with non-zero block range is currently zeroed. Also this
behaviour leads to segfault since we schedule iocb->bh two times.
First when entering nvme_dsm_cb with iocb->idx == iocb->nr and
second because of missing return on call stack unwinding by calling
blk_aio_pwrite_zeroes and subsequent nvme_dsm_cb callback.

Fixes: d7d1474fd85d ("hw/nvme: reimplement dsm to allow cancellation")
Signed-off-by: Dmitry Tikhov <d.tihov@yadro.com>
Reviewed-by: Klaus Jensen <k.jensen@samsung.com>
Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
hw/nvme/ctrl.c