OSDN Git Service

ethtool: Fix NULL pointer dereference during module EEPROM dump
authorIdo Schimmel <idosch@nvidia.com>
Sun, 6 Jun 2021 14:24:22 +0000 (17:24 +0300)
committerDavid S. Miller <davem@davemloft.net>
Mon, 7 Jun 2021 20:10:34 +0000 (13:10 -0700)
commit51c96a561f244e25a4a2afc7a48b92b4adf8050d
tree27dd355dfbda79e0da1d6a46234d3fef171a18ec
parent3822d0670c9d4342794d73e0d0e615322b40438e
ethtool: Fix NULL pointer dereference during module EEPROM dump

When get_module_eeprom_by_page() is not implemented by the driver, NULL
pointer dereference can occur [1].

Fix by testing if get_module_eeprom_by_page() is implemented instead of
get_module_info().

[1]
 BUG: kernel NULL pointer dereference, address: 0000000000000000
 [...]
 CPU: 0 PID: 251 Comm: ethtool Not tainted 5.13.0-rc3-custom-00940-g3822d0670c9d #989
 Call Trace:
  eeprom_prepare_data+0x101/0x2d0
  ethnl_default_doit+0xc2/0x290
  genl_family_rcv_msg_doit+0xdc/0x140
  genl_rcv_msg+0xd7/0x1d0
  netlink_rcv_skb+0x49/0xf0
  genl_rcv+0x1f/0x30
  netlink_unicast+0x1f6/0x2c0
  netlink_sendmsg+0x1f9/0x400
  __sys_sendto+0xe1/0x130
  __x64_sys_sendto+0x1b/0x20
  do_syscall_64+0x3a/0x70
  entry_SYSCALL_64_after_hwframe+0x44/0xae

Fixes: c97a31f66ebc ("ethtool: wire in generic SFP module access")
Signed-off-by: Ido Schimmel <idosch@nvidia.com>
Acked-by: Moshe Shemesh <moshe@nvidia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ethtool/eeprom.c