OSDN Git Service

nfsd: encoders mustn't use unitialized values in error cases
authorJ. Bruce Fields <bfields@redhat.com>
Fri, 5 May 2017 20:17:57 +0000 (16:17 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 25 May 2017 12:30:18 +0000 (14:30 +0200)
commit52cf24769487de7100d824e8c12ecc310de841d7
tree4d20e59dcaac709998c44d770ccac179f351d4d3
parentda922dc48dcf0d4412905c4856a36aa0147699ed
nfsd: encoders mustn't use unitialized values in error cases

commit f961e3f2acae94b727380c0b74e2d3954d0edf79 upstream.

In error cases, lgp->lg_layout_type may be out of bounds; so we
shouldn't be using it until after the check of nfserr.

This was seen to crash nfsd threads when the server receives a LAYOUTGET
request with a large layout type.

GETDEVICEINFO has the same problem.

Reported-by: Ari Kauppi <Ari.Kauppi@synopsys.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/nfsd/nfs4xdr.c