OSDN Git Service

netfs: Miscellaneous fixes
authorDavid Howells <dhowells@redhat.com>
Mon, 26 Apr 2021 20:16:16 +0000 (21:16 +0100)
committerDavid Howells <dhowells@redhat.com>
Mon, 26 Apr 2021 22:23:41 +0000 (23:23 +0100)
commit53b776c77aca99b663a5512a04abc27670d61058
tree8b2144f8c4f1ddf47489c09605b646b03a032b93
parent3d14ec1fe61aebe3da85a9b8f2c3d61e43d522e6
netfs: Miscellaneous fixes

Fix some miscellaneous things in the new netfs lib[1]:

 (1) The kerneldoc for netfs_readpage() shouldn't say netfs_page().

 (2) netfs_readpage() can get an integer overflow on 32-bit when it
     multiplies page_index(page) by PAGE_SIZE.  It should use
     page_file_offset() instead.

 (3) netfs_write_begin() should use page_offset() to avoid the same
     overflow.

Note that netfs_readpage() needs to use page_file_offset() rather than
page_offset() as it may see swap-over-NFS.

Reported-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Signed-off-by: David Howells <dhowells@redhat.com>
Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Link: https://lore.kernel.org/r/161789062190.6155.12711584466338493050.stgit@warthog.procyon.org.uk/
fs/netfs/read_helper.c