OSDN Git Service

drm/sun4i: hdmi: Disable clks in bind function error path and unbind function
authorChen-Yu Tsai <wens@csie.org>
Tue, 10 Oct 2017 03:20:00 +0000 (11:20 +0800)
committerMaxime Ripard <maxime.ripard@free-electrons.com>
Wed, 11 Oct 2017 07:52:58 +0000 (09:52 +0200)
commit544c5048bcdc5d5c395d99d61ab7a52964a1420b
tree8caf9cc1a930d641cce19c94c0f32bb8b521cdc6
parent67e326450d7af554e80fbbac73b2b65b6468afca
drm/sun4i: hdmi: Disable clks in bind function error path and unbind function

The HDMI driver enables the bus and mod clocks in the bind function, but
does not disable them if it then bails our due to any errors. Neither
does it disable the clocks in the unbind function.

Fix this by adding a proper error path to the bind function, and
clk_disable_unprepare calls to the unbind function.

Also rename the err_cleanup_connector label to err_cleanup_encoder,
since it is the encoder that gets cleaned up.

Fixes: 9c5681011a0c ("drm/sun4i: Add HDMI support")
Signed-off-by: Chen-Yu Tsai <wens@csie.org>
Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20171010032008.682-4-wens@csie.org
drivers/gpu/drm/sun4i/sun4i_hdmi_enc.c