OSDN Git Service

drm/vc4: txp: Force alpha to be 0xff if it's disabled
authorMaxime Ripard <maxime@cerno.tech>
Mon, 28 Mar 2022 15:36:56 +0000 (17:36 +0200)
committerMaxime Ripard <maxime@cerno.tech>
Fri, 8 Apr 2022 11:38:06 +0000 (13:38 +0200)
commit5453343a88ede8b12812fced81ecd24cb888ccc3
tree5a1903e4bd14b3465f1d9bf3fad403663ea1d71f
parent234998df929f14d00cbf2f1e81a7facb69fd9266
drm/vc4: txp: Force alpha to be 0xff if it's disabled

If we use a format that has padding instead of the alpha component (such
as XRGB8888), it appears that the Transposer will fill the padding to 0,
disregarding what was stored in the input buffer padding.

This leads to issues with IGT, since it will set the padding to 0xff,
but will then compare the CRC of the two frames which will thus fail.
Another nice side effect is that it is now possible to just use the
buffer as ARGB.

Fixes: 008095e065a8 ("drm/vc4: Add support for the transposer block")
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
Link: https://lore.kernel.org/r/20220328153659.2382206-4-maxime@cerno.tech
drivers/gpu/drm/vc4/vc4_txp.c