OSDN Git Service

drm/v3d: Don't clear MMU control bits on exception
authorPhil Elwell <phil@raspberrypi.org>
Wed, 23 Dec 2020 20:35:13 +0000 (21:35 +0100)
committerMaxime Ripard <maxime@cerno.tech>
Wed, 6 Jan 2021 17:38:57 +0000 (18:38 +0100)
commit545d9d780262fcff6ed48dcd812a816cd88e5003
tree8df1a3d506161d871a5b8e44d8272ec9c9ffed5f
parent334dd38a3878a8fba1cfaa3c715163226de3cddc
drm/v3d: Don't clear MMU control bits on exception

MMU exception conditions are reported in the V3D_MMU_CTRL register as
write-1-to-clear (W1C) bits. The MMU interrupt handling code clears any
exceptions, but does so by masking out any other bits and writing the
result back. There are some important control bits in that register,
including MMU_ENABLE, so a safer approach is to simply write back the
value just read unaltered.

Signed-off-by: Phil Elwell <phil@raspberrypi.org>
Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
Reviewed-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Link: https://patchwork.freedesktop.org/patch/msgid/1608755714-18233-4-git-send-email-stefan.wahren@i2se.com
drivers/gpu/drm/v3d/v3d_irq.c