OSDN Git Service

Revert "platform/x86: wmi: Destroy on cleanup rather than unregister"
authorYongxin Liu <yongxin.liu@windriver.com>
Fri, 15 Nov 2019 05:27:10 +0000 (13:27 +0800)
committerHans de Goede <hdegoede@redhat.com>
Tue, 27 Oct 2020 14:35:56 +0000 (15:35 +0100)
commit56afb8d48017cbc5216ce3923f11d65683a8e0b6
tree85cea4718b8b91d89e44616ac89cfccb79dda110
parent411269babe8374b7777a0f154a2ad27c3c6dc218
Revert "platform/x86: wmi: Destroy on cleanup rather than unregister"

This reverts commit 7b11e8989618581bc0226ad313264cdc05d48d86.

Consider the following hardware setting.

|-PNP0C14:00
|  |-- device #1
|-PNP0C14:01
|  |-- device #2

When unloading wmi driver module, device #2 will be first unregistered.
But device_destroy() using MKDEV(0, 0) will locate PNP0C14:00 first
and unregister it. This is incorrect. Should use device_unregister() to
unregister the real parent device.

Signed-off-by: Yongxin Liu <yongxin.liu@windriver.com>
Link: https://lore.kernel.org/r/20191115052710.46880-1-yongxin.liu@windriver.com
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
drivers/platform/x86/wmi.c