OSDN Git Service

(root) / uclinux-h8 / linux.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: a7a9b15) | patch
hwmon: (w83773g) Fix fault detection and reporting
authorGuenter Roeck <linux@roeck-us.net>
Sun, 3 Dec 2017 23:27:56 +0000 (15:27 -0800)
committerGuenter Roeck <linux@roeck-us.net>
Tue, 2 Jan 2018 23:05:34 +0000 (15:05 -0800)
commit571e3f3a8e6582ecce2c7fd5d0a9e2ae74cece02
tree1e9fa4097eb343ac524f4e2ddc35ec5288f9ef91tree | snapshot
parenta7a9b15a35d2504aa83e140d4cf50c85ac01e965commit | diff
hwmon: (w83773g) Fix fault detection and reporting

Smatch reports:

drivers/hwmon/w83773g.c:105
get_fault() warn: shift has higher precedence than mask

Code analysis shows that the code is indeed wrong.
Fix it, and while we are at it, drop unnecessary typecast.

Fixes: 86a10c802362 ("hwmon: Add W83773G driver")
Cc: Lei YU <mine260309@gmail.com>
Reviewed-by: Lei YU <mine260309@gmail.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
drivers/hwmon/w83773g.c diff | blob | history
About OSDN
Find Software
Develop Software
Help