OSDN Git Service

net: appletalk: cops: Fix data race in cops_probe1
authorSaubhik Mukherjee <saubhik.mukherjee@gmail.com>
Mon, 24 May 2021 13:37:12 +0000 (19:07 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 16 Jun 2021 09:54:58 +0000 (11:54 +0200)
commit57372e2926fe4796a3c25b1448cb041d8cfa3c78
treea858d1d15a577c5a303aea662ce634e57a13c0ce
parent91d25454ec8e7d0530e94c2b6f3e53a47a7f62a0
net: appletalk: cops: Fix data race in cops_probe1

[ Upstream commit a4dd4fc6105e54393d637450a11d4cddb5fabc4f ]

In cops_probe1(), there is a write to dev->base_addr after requesting an
interrupt line and registering the interrupt handler cops_interrupt().
The handler might be called in parallel to handle an interrupt.
cops_interrupt() tries to read dev->base_addr leading to a potential
data race. So write to dev->base_addr before calling request_irq().

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Saubhik Mukherjee <saubhik.mukherjee@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/appletalk/cops.c