OSDN Git Service

platform/x86: dell-laptop: Fix backlight detection
authorDamien Thébault <damien@dtbo.net>
Wed, 18 Jul 2018 10:06:01 +0000 (12:06 +0200)
committerAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Tue, 31 Jul 2018 14:40:36 +0000 (17:40 +0300)
commit5788f77959110480486c441b912da5c2cc5fc4d2
tree0820284b547a1f57f4a22bb72b0d62cd5ba74e61
parentc2e2a618eb7104e18fdcf739d4d911563812a81c
platform/x86: dell-laptop: Fix backlight detection

Fix return code check for "max brightness" ACPI call.

The Dell laptop ACPI video brightness control is not present on dell
laptops anymore, but was present in older kernel versions.

The code that checks the return value is incorrect since the SMM
refactoring.

The old code was:
  if (buffer->output[0] == 0)

Which was changed to:
  ret = dell_send_request(...)
  if (ret)

However, dell_send_request() will return 0 if buffer->output[0] == 0,
so we must change the check to:
  if (ret == 0)

This issue was found on a Dell M4800 laptop, and the fix tested on it
as well.

Fixes: 549b4930f057 ("dell-smbios: Introduce dispatcher for SMM calls")
Signed-off-by: Damien Thébault <damien@dtbo.net>
Tested-by: Damien Thébault <damien@dtbo.net>
Reviewed-by: Pali Rohár <pali.rohar@gmail.com>
Reviewed-by: Mario Limonciello <mario.limonciello@dell.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
drivers/platform/x86/dell-laptop.c