OSDN Git Service

ASoC: mediatek: fix unmet dependency on GPIOLIB for SND_SOC_DMIC
authorJulian Braha <julianbraha@gmail.com>
Mon, 17 Jan 2022 05:03:24 +0000 (00:03 -0500)
committerMark Brown <broonie@kernel.org>
Wed, 19 Jan 2022 16:47:37 +0000 (16:47 +0000)
commit579b2c8f72d974f27d85bbd53846f34675ee3b01
tree63cdcbe92a2b30dd74585e40ae7665f5cc847844
parent4c907bcd9dcd233da6707059d777ab389dcbd964
ASoC: mediatek: fix unmet dependency on GPIOLIB for SND_SOC_DMIC

When SND_SOC_MT8195_MT6359_RT1011_RT5682 is selected,
and GPIOLIB is not selected,
Kbuild gives the following warning:

WARNING: unmet direct dependencies detected for SND_SOC_DMIC
  Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && GPIOLIB [=n]
  Selected by [y]:
  - SND_SOC_MT8195_MT6359_RT1011_RT5682 [=y] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=y] && I2C [=y] && SND_SOC_MT8195 [=y] && MTK_PMIC_WRAP [=y]

This is because SND_SOC_MT8195_MT6359_RT1011_RT5682
selects SND_SOC_DMIC without selecting or depending on
GPIOLIB, depsite SND_SOC_DMIC depending on GPIOLIB.

This unmet dependency bug was detected by Kismet,
a static analysis tool for Kconfig. Please advise
if this is not the appropriate solution.

Signed-off-by: Julian Braha <julianbraha@gmail.com>
Reviewed-by: Tzung-Bi Shih <tzungbi@google.com>
Link: https://lore.kernel.org/r/20220117050324.68371-1-julianbraha@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/mediatek/Kconfig