OSDN Git Service

scsi: scsi_dh_rdac: zero cdb in send_mode_select()
authorMartin Wilck <Martin.Wilck@suse.com>
Wed, 4 Sep 2019 15:52:29 +0000 (15:52 +0000)
committerMartin K. Petersen <martin.petersen@oracle.com>
Wed, 11 Sep 2019 01:25:36 +0000 (21:25 -0400)
commit57adf5d4cfd3198aa480e7c94a101fc8c4e6109d
tree51145c849c65b651c94e73d5fb285798b9515dfc
parentf96d279f0a5e53f4b96b16a5c08e2c75e139ba0b
scsi: scsi_dh_rdac: zero cdb in send_mode_select()

cdb in send_mode_select() is not zeroed and is only partially filled in
rdac_failover_get(), which leads to some random data getting to the
device. Users have reported storage responding to such commands with
INVALID FIELD IN CDB. Code before commit 327825574132 was not affected, as
it called blk_rq_set_block_pc().

Fix this by zeroing out the cdb first.

Identified & fix proposed by HPE.

Fixes: 327825574132 ("scsi_dh_rdac: switch to scsi_execute_req_flags()")
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20190904155205.1666-1-martin.wilck@suse.com
Signed-off-by: Martin Wilck <mwilck@suse.com>
Acked-by: Ales Novak <alnovak@suse.cz>
Reviewed-by: Shane Seymour <shane.seymour@hpe.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/device_handler/scsi_dh_rdac.c