OSDN Git Service

blockdev: Fix wrong usage of QDECREF causing snapshoted quorum to crash on close.
authorBenoît Canet <benoit.canet@irqsave.net>
Thu, 13 Feb 2014 16:22:33 +0000 (17:22 +0100)
committerStefan Hajnoczi <stefanha@redhat.com>
Fri, 14 Feb 2014 17:05:39 +0000 (18:05 +0100)
commit57b6bdf37c64985cf02b8737c550d52759059c9d
tree7af75dbbd25f396f1665f479fffb3397b57c9336
parentcc67f4d1f9645e8e6d90aee84ca19162d661f082
blockdev: Fix wrong usage of QDECREF causing snapshoted quorum to crash on close.

As bdrv_open() documentation states:
"The reference to the QDict belongs to the block layer
 * after the call (even on failure), so if the caller intends to reuse the
 * dictionary, it needs to use QINCREF() before calling bdrv_open."

the optional options dict will not be reused after bdrv_open() and should
belong to the block layer so remove the extra QDECREF(options).

Signed-off-by: Benoit Canet <benoit@irqsave.net>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
blockdev.c