OSDN Git Service

drm/sun4i: fix build failure with CONFIG_DRM_SUN8I_MIXER=m
authorArnd Bergmann <arnd@arndb.de>
Wed, 11 Jul 2018 14:43:10 +0000 (16:43 +0200)
committerMaxime Ripard <maxime.ripard@bootlin.com>
Thu, 12 Jul 2018 07:35:19 +0000 (09:35 +0200)
commit58d4d29823d9a6c4593c48a1a24e6a9dcec8e3ff
tree7090803321ef866a49d52acc62600c575036721d
parent7da9b2e47fefb419a21e1c4c5a0682846b41b4a0
drm/sun4i: fix build failure with CONFIG_DRM_SUN8I_MIXER=m

Having DRM_SUN4I built-in but DRM_SUN8I_MIXER as a loadable module results in
a link error, as we try to access a symbol from the sun8i_tcon_top.ko module:

ERROR: "sun8i_tcon_top_of_table" [drivers/gpu/drm/sun4i/sun8i-drm-hdmi.ko] undefined!
ERROR: "sun8i_tcon_top_of_table" [drivers/gpu/drm/sun4i/sun4i-drm.ko] undefined!

This solves the problem by adding a silent symbol for the tcon_top module,
building it as a separate module in exactly the cases that we need it,
but in a way that it is reachable by the other modules.

Fixes: 57e23de02f48 ("drm/sun4i: DW HDMI: Expand algorithm for possible crtcs")
Fixes: ef0cf6441fbb ("drm/sun4i: Add support for traversing graph with TCON TOP")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20180711144403.1022829-1-arnd@arndb.de
drivers/gpu/drm/sun4i/Kconfig
drivers/gpu/drm/sun4i/Makefile
drivers/gpu/drm/sun4i/sun4i_drv.c
drivers/gpu/drm/sun4i/sun8i_dw_hdmi.c