OSDN Git Service

Avoid crash when setting buffer on deleted layer
authorSteven Thomas <steventhomas@google.com>
Wed, 26 Apr 2017 22:24:28 +0000 (15:24 -0700)
committerSteven Thomas <steventhomas@google.com>
Tue, 2 May 2017 17:39:39 +0000 (17:39 +0000)
commit58da77ea4b7be4ecb0fee10d20b0e405de7eb2be
treea472f115541e25d5ec35d52793d406cc641bf829
parent9f5b6aaf73ce88f8ca751fcb236b9a9e8f220d78
Avoid crash when setting buffer on deleted layer

When setLayerBuffer() was called on a layer previously destroyed by
destroyLayer() the code would crash. Instead, return an error.

Bug: 37159844

Test: Ran vr flinger in a way that would trigger the crash, and
confirmed that I now get error logs instead of crashing. Unfortunately
the error code is consumed by the Composer wrapper class and not
propagated back to the caller, but that's a separate issue (b/37901601).

Change-Id: I75a5b954d47a1deac44d03851f60f347085eca89
graphics/composer/2.1/default/ComposerClient.cpp
graphics/composer/2.1/default/ComposerClient.h