OSDN Git Service

libbpf: Fix strncat bounds error in libbpf_prog_type_by_name
authorKP Singh <kpsingh@google.com>
Wed, 23 Oct 2019 15:40:38 +0000 (17:40 +0200)
committerAlexei Starovoitov <ast@kernel.org>
Wed, 23 Oct 2019 17:17:28 +0000 (10:17 -0700)
commit58eeb2289ab9bd8acad41a589431bbdbf7622595
treeba8da2fe69745243100e76539a4e926f46e68a36
parente0e4f8e938c48b7c5377661fa3e4738901e6a19b
libbpf: Fix strncat bounds error in libbpf_prog_type_by_name

On compiling samples with this change, one gets an error:

 error: â€˜strncat’ specified bound 118 equals destination size
  [-Werror=stringop-truncation]

    strncat(dst, name + section_names[i].len,
    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     sizeof(raw_tp_btf_name) - (dst - raw_tp_btf_name));
     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

strncat requires the destination to have enough space for the
terminating null byte.

Fixes: f75a697e09137 ("libbpf: Auto-detect btf_id of BTF-based raw_tracepoint")
Signed-off-by: KP Singh <kpsingh@google.com>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Link: https://lore.kernel.org/bpf/20191023154038.24075-1-kpsingh@chromium.org
tools/lib/bpf/libbpf.c