OSDN Git Service

drm/vmwgfx: Fix possible usage of an uninitialized variable
authorZack Rusin <zackr@vmware.com>
Wed, 15 Dec 2021 20:02:24 +0000 (15:02 -0500)
committerThomas Zimmermann <tzimmermann@suse.de>
Fri, 17 Dec 2021 15:35:30 +0000 (16:35 +0100)
commit58fa0d90eddeda37b32597eda139e888ebe5af04
tree9348b3eeee3997deb71ddec6680bf674c3fd36ae
parent50ca8cc7c0fdd9ab16b8b66ffb301fface101fac
drm/vmwgfx: Fix possible usage of an uninitialized variable

vmw_user_bo_lookup can fail to lookup user buffers, especially because
the buffer handles come from the userspace. The return value has
to be checked before the buffers are put back.

This was spotted by Dan's Smatch statick checker:
    drivers/gpu/drm/vmwgfx/vmwgfx_bo.c:574 vmw_user_bo_synccpu_release()
error: uninitialized symbol 'vmw_bo'.

Signed-off-by: Zack Rusin <zackr@vmware.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Fixes: 8afa13a0583f ("drm/vmwgfx: Implement DRIVER_GEM")
Reviewed-by: Martin Krastev <krastevm@vmware.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20211215200224.3693345-1-zack@kde.org
(cherry picked from commit 60c9ecd705be3a28f79d70ea21c3939db668bf46)
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
drivers/gpu/drm/vmwgfx/vmwgfx_bo.c