OSDN Git Service

dm bufio: avoid false-positive Wmaybe-uninitialized warning
authorArnd Bergmann <arnd@arndb.de>
Thu, 22 Feb 2018 15:56:16 +0000 (16:56 +0100)
committerMike Snitzer <snitzer@redhat.com>
Wed, 7 Mar 2018 01:23:57 +0000 (20:23 -0500)
commit590347e4000356f55eb10b03ced2686bd74dab40
tree7c38592e2dfa00683559b9e5a473f2fd2a2fa0d8
parent661e50bc853209e41a5c14a290ca4decc43cbfd1
dm bufio: avoid false-positive Wmaybe-uninitialized warning

gcc-6.3 and earlier show a new warning after a seemingly unrelated
change to the arm64 PAGE_KERNEL definition:

In file included from drivers/md/dm-bufio.c:14:0:
drivers/md/dm-bufio.c: In function 'alloc_buffer':
include/linux/sched/mm.h:182:56: warning: 'noio_flag' may be used uninitialized in this function [-Wmaybe-uninitialized]
  current->flags = (current->flags & ~PF_MEMALLOC_NOIO) | flags;
                                                        ^

The same warning happened earlier on linux-3.18 for MIPS and I did a
workaround for that, but now it's come back.

gcc-7 and newer are apparently smart enough to figure this out, and
other architectures don't show it, so the best I could come up with is
to rework the caller slightly in a way that makes it obvious enough to
all arm64 compilers what is happening here.

Fixes: 41acec624087 ("arm64: kpti: Make use of nG dependent on arm64_kernel_unmapped_at_el0()")
Link: https://patchwork.kernel.org/patch/9692829/
Cc: stable@vger.kernel.org
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
[snitzer: moved declarations inside conditional, altered vmalloc return]
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
drivers/md/dm-bufio.c