OSDN Git Service

drm/panfrost: Fix possible suspend in panfrost_remove
authorRob Herring <robh@kernel.org>
Fri, 23 Aug 2019 02:12:09 +0000 (21:12 -0500)
committerRob Herring <robh@kernel.org>
Fri, 23 Aug 2019 16:54:06 +0000 (11:54 -0500)
commit593bc4d008cf75daa924f73bd39b34dd03c4e8de
tree0d7ff171c4ca2e9907f376226fbfb946c424a0ee
parent97588c89993d1fb6bf4026984c0c099a5122b0b2
drm/panfrost: Fix possible suspend in panfrost_remove

Calls to panfrost_device_fini() access the h/w, but we already done a
pm_runtime_put_sync_autosuspend() beforehand. This only works if the
autosuspend delay is long enough. A 0ms delay will hang the system when
removing the device. Fix this by moving the pm_runtime_put_sync_suspend()
after the panfrost_device_fini() call.

Cc: Tomeu Vizoso <tomeu.vizoso@collabora.com>
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Signed-off-by: Rob Herring <robh@kernel.org>
Reviewed-by: Steven Price <steven.price@arm.com>
Acked-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190823021216.5862-2-robh@kernel.org
drivers/gpu/drm/panfrost/panfrost_drv.c