OSDN Git Service

ASoC: soc-dapm.c: tidyup snd_soc_dai_link_event_pre_pmu()
authorKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Thu, 8 Sep 2022 02:45:27 +0000 (02:45 +0000)
committerMark Brown <broonie@kernel.org>
Thu, 8 Sep 2022 10:39:40 +0000 (11:39 +0100)
commit59a1063dcaa5c9450dc1d221679418747bf086fc
tree5c5c869fd63cc08a02566d7d9853424985dec892
parent6ef8443fb1ced148417d830894240a097ba79a03
ASoC: soc-dapm.c: tidyup snd_soc_dai_link_event_pre_pmu()

snd_soc_dai_link_event_pre_pmu() is using if/else for config->formats
check, but "else" case is for just error.
Unnecessary if/else is not good for readable code. this patch checks
if config->formats was zero as error case.

Moreover, we don't need to indicate config->formats value in error message,
because it is zero. This patch tidyup it, too.

=> if (config->formats) {
...
} else {
dev_warn(w->dapm->dev, "ASoC: Invalid format %llx specified\n",
=>  config->formats);
...
}

Link: https://lore.kernel.org/all/YxiDkDOwRsbXeZ17@sirena.org.uk/
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://lore.kernel.org/r/877d2ebn3t.wl-kuninori.morimoto.gx@renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/soc-dapm.c