OSDN Git Service

net: ocelot: Add of_node_put() before return statement
authorSumera Priyadarsini <sylphrenadin@gmail.com>
Sun, 23 Aug 2020 13:52:45 +0000 (19:22 +0530)
committerDavid S. Miller <davem@davemloft.net>
Tue, 25 Aug 2020 01:04:09 +0000 (18:04 -0700)
commit59ebb4305c432b6ca34fd9704c9294c1f16e5847
treee8d892d24cc2d6de7c2a19a5abcb17c6ea09c93e
parent4341b7d9164093c14edc686deac6a9f36eb661b5
net: ocelot: Add of_node_put() before return statement

Every iteration of for_each_available_child_of_node() decrements
the reference count of the previous node, however when control
is transferred from the middle of the loop, as in the case of
a return or break or goto, there is no decrement thus ultimately
resulting in a memory leak.

Fix a potential memory leak in felix.c by inserting of_node_put()
before the return statement.

Issue found with Coccinelle.

Signed-off-by: Sumera Priyadarsini <sylphrenadin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/dsa/ocelot/felix.c