OSDN Git Service

sched/fair: Fix reordering of enqueue/dequeue_task_fair()
authorVincent Guittot <vincent.guittot@linaro.org>
Fri, 6 Mar 2020 08:42:08 +0000 (09:42 +0100)
committerIngo Molnar <mingo@kernel.org>
Fri, 6 Mar 2020 11:57:25 +0000 (12:57 +0100)
commit5ab297bab984310267734dfbcc8104566658ebef
tree51fbe5f5090fb7681cfb4d12612344afd944d30b
parent6212437f0f6043e825e021e4afc5cd63e248a2b4
sched/fair: Fix reordering of enqueue/dequeue_task_fair()

Even when a cgroup is throttled, the group se of a child cgroup can still
be enqueued and its gse->on_rq stays true. When a task is enqueued on such
child, we still have to update the load_avg and increase
h_nr_running of the throttled cfs. Nevertheless, the 1st
for_each_sched_entity() loop is skipped because of gse->on_rq == true and the
2nd loop because the cfs is throttled whereas we have to update both
load_avg with the old h_nr_running and increase h_nr_running in such case.

The same sequence can happen during dequeue when se moves to parent before
breaking in the 1st loop.

Note that the update of load_avg will effectively happen only once in order
to sync up to the throttled time. Next call for updating load_avg will stop
early because the clock stays unchanged.

Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Fixes: 6d4d22468dae ("sched/fair: Reorder enqueue/dequeue_task_fair path")
Link: https://lkml.kernel.org/r/20200306084208.12583-1-vincent.guittot@linaro.org
kernel/sched/fair.c