OSDN Git Service

drm/i915: Don't check tc_mode unless dealing with a TC PHY
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Thu, 28 Jan 2021 15:59:48 +0000 (17:59 +0200)
committerVille Syrjälä <ville.syrjala@linux.intel.com>
Fri, 29 Jan 2021 23:42:37 +0000 (01:42 +0200)
commit5b6a9ba9f6cefa41b2dd9b0c9ba36646b81ce0a1
treec6cc70ce5c95844dadef1920873b24dc862eb803
parentc9b69041f0e0f3b6f2019c81ffe3b732f605ea00
drm/i915: Don't check tc_mode unless dealing with a TC PHY

We shouldn't really trust tc_mode on non-TC PHYs since we never
initialize it explicitly. So let's check for the PHY type first.
Fortunately TC_PORT_TBT_ALT happens to be zero so I don't think
there's an actual bug here, just a possibility for a future one
if someone rearranges the enum values.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20210128155948.13678-5-ville.syrjala@linux.intel.com
Reviewed-by: Imre Deak <imre.deak@intel.com>
drivers/gpu/drm/i915/display/intel_ddi.c